fix(deps): security package updates - #5
Open
Nisarg48 wants to merge 4 commits into
Open
Conversation
Bump tooling parents and migrate the workspace from Nx 20 to 23 without overrides so CI stays green and Vanta findings from outdated packages are cleared.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 24 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
nx.json:113
- This enables Nx analytics/telemetry at the workspace level (
"analytics": true). That can unintentionally send usage data from CI and developer machines and is unrelated to the dependency security bump described in the PR.
"analytics": true,
nx.json:6
- Nx is configured to use npm (
cli.packageManager: "npm"), but the repo still contains ayarn.lockalongsidepackage-lock.json. Keeping multiple lockfiles tends to cause dependency drift and confusion about which package manager is supported.
"cli": {
"packageManager": "npm"
},
| "strictFunctionTypes": true, | ||
| "strictPropertyInitialization": true, | ||
| "alwaysStrict": true, | ||
| "ignoreDeprecations": "6.0", |
KrishKashiwala
suggested changes
Aug 11, 2026
KrishKashiwala
suggested changes
Aug 11, 2026
Comment on lines
+4
to
+6
| "cli": { | ||
| "packageManager": "npm" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@nx/vite/vitepins to match the workspace (no nested Nx 20)minimatchandwsresolve to patched versions within parent rangesoverrides/npm audit fix --forceNotes
brace-expansion2.x → ≥2.1.3)npm auditmay still report Nx’s nestedbrace-expansion5.0.8; that is separate from the Vanta 2.x CVE and needs an upstream Nx release (or a temporary override)